Add custom_event and webview reload Platform APIs#76
Merged
Conversation
Provide Desktop.Platform.System.custom_event/2 for mobile bridge custom events (replacing Hex Bridge GenServer calls) and Desktop.Window.reload/1 plus Content.reload/1 as the backend-safe replacement for :wxWebView.reload/1. Co-authored-by: Cursor <[email protected]>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Desktop.Platform.System.custom_event/2for mobile-native events ([:custom_event, event, args]wire format) — replaces HexBridgeGenServer.callDesktop.Platform.Content.reload/1andDesktop.Window.reload/1— replaces:wxWebView.reload/1Needed by diode-drive after the Bridge embed: share/save/restart custom events and UI webview reload still used the removed Hex
Bridge/ raw:wxWebViewpaths on Android.Test plan
NO_WX=1 mix test test/desktop/backend/json_test.exs test/desktop/backend/browser_test.exs test/desktop/platform_system_test.exs test/desktop/regression/beam_wx_calls_test.exs --exclude wxmix test.guardxvfb-run mix test.wxfor Wx reload coverageMade with Cursor